New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Trinity 2.6.6 #1937
Trinity 2.6.6 #1937
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work @abretaud! I just have two small comments :)
<option value="no">No</option> | ||
</param> | ||
<when value="yes"> | ||
<param format="tabular" name="gene_trans_map" argument="--gene_trans_map" type="data" label="Gene to transcript correspondence ('gene(tab)transcript' lines)" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you not just use the param and make it optional and remove the conditional?
tools/trinity/super_transcripts.xml
Outdated
</macros> | ||
<expand macro="requirements"/> | ||
<command detect_errors="aggressive"><![CDATA[ | ||
Trinity_gene_splice_modeler.py --incl_malign --trinity_fasta "$assembly" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
single quotes
Thanks @abretaud! |
Hi, Lucille |
@lldelisle there's a conda package for this version of trinity (https://anaconda.org/bioconda/trinity) |
Here's an update from Trinity 2.4.0 to 2.6.6
Now there's a wrapper to generate super transcripts.
As things would have been too simple with just changing the
@WRAPPER_VERSION@
, I also add to update a few dependencies, countless test data, and update some wrappers a now trinity generates a gene map that needs to be reused by some of the scripts (replacing--trinity_mode
)