Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trinity 2.6.6 #1937

Merged
merged 11 commits into from Jun 14, 2018
Merged

Trinity 2.6.6 #1937

merged 11 commits into from Jun 14, 2018

Conversation

abretaud
Copy link
Contributor

Here's an update from Trinity 2.4.0 to 2.6.6
Now there's a wrapper to generate super transcripts.
As things would have been too simple with just changing the @WRAPPER_VERSION@, I also add to update a few dependencies, countless test data, and update some wrappers a now trinity generates a gene map that needs to be reused by some of the scripts (replacing --trinity_mode)

Copy link
Member

@bgruening bgruening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @abretaud! I just have two small comments :)

<option value="no">No</option>
</param>
<when value="yes">
<param format="tabular" name="gene_trans_map" argument="--gene_trans_map" type="data" label="Gene to transcript correspondence ('gene(tab)transcript' lines)" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you not just use the param and make it optional and remove the conditional?

</macros>
<expand macro="requirements"/>
<command detect_errors="aggressive"><![CDATA[
Trinity_gene_splice_modeler.py --incl_malign --trinity_fasta "$assembly"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

single quotes

@bgruening bgruening merged commit 9dcdb53 into galaxyproject:master Jun 14, 2018
@bgruening
Copy link
Member

Thanks @abretaud!

@lldelisle
Copy link
Contributor

Hi,
In my private instance, the dependency is not solved. Is there a package trinity 2.6.6 to download?
Many thanks,

Lucille

@abretaud
Copy link
Contributor Author

@lldelisle there's a conda package for this version of trinity (https://anaconda.org/bioconda/trinity)
If your galaxy is configured to use conda for dependency resolution, it should install automatically
We no longer maintain old-style tool_dependency.xml for trinity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants